-
-
Notifications
You must be signed in to change notification settings - Fork 97
enhance: state.entityMeta -> state.entitiesMeta #3451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 613f653 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +3 B (0%) Total Size: 77.8 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 613f653 | Previous: 49a5fd3 | Ratio |
---|---|---|---|
normalizeLong |
504 ops/sec (±0.26% ) |
496 ops/sec (±1.08% ) |
0.98 |
infer All |
9031 ops/sec (±1.88% ) |
9212 ops/sec (±1.13% ) |
1.02 |
denormalizeLong |
259 ops/sec (±3.22% ) |
268 ops/sec (±2.61% ) |
1.03 |
denormalizeLong donotcache |
981 ops/sec (±0.27% ) |
971 ops/sec (±0.37% ) |
0.99 |
denormalizeShort donotcache 500x |
1408 ops/sec (±0.71% ) |
1404 ops/sec (±1.00% ) |
1.00 |
denormalizeShort 500x |
788 ops/sec (±2.03% ) |
763 ops/sec (±2.22% ) |
0.97 |
denormalizeShort 500x withCache |
5310 ops/sec (±0.31% ) |
5193 ops/sec (±0.89% ) |
0.98 |
queryShort 500x withCache |
2413 ops/sec (±0.23% ) |
2374 ops/sec (±0.63% ) |
0.98 |
denormalizeLong with mixin Entity |
255 ops/sec (±2.04% ) |
253 ops/sec (±2.26% ) |
0.99 |
denormalizeLong withCache |
6948 ops/sec (±0.17% ) |
6799 ops/sec (±0.39% ) |
0.98 |
denormalizeLong All withCache |
8086 ops/sec (±0.32% ) |
7888 ops/sec (±0.33% ) |
0.98 |
denormalizeLong Query-sorted withCache |
7649 ops/sec (±0.59% ) |
7556 ops/sec (±0.77% ) |
0.99 |
denormalizeLongAndShort withEntityCacheOnly |
1683 ops/sec (±0.71% ) |
1686 ops/sec (±0.50% ) |
1.00 |
getResponse |
5999 ops/sec (±1.11% ) |
6156 ops/sec (±1.16% ) |
1.03 |
getResponse (null) |
5572387 ops/sec (±0.71% ) |
5506274 ops/sec (±0.58% ) |
0.99 |
getResponse (clear cache) |
247 ops/sec (±2.19% ) |
247 ops/sec (±2.00% ) |
1 |
getSmallResponse |
2590 ops/sec (±0.63% ) |
2643 ops/sec (±0.24% ) |
1.02 |
getSmallInferredResponse |
2075 ops/sec (±0.26% ) |
2138 ops/sec (±0.53% ) |
1.03 |
getResponse Collection |
6687 ops/sec (±1.06% ) |
5969 ops/sec (±0.85% ) |
0.89 |
get Collection |
5614 ops/sec (±0.41% ) |
5441 ops/sec (±0.48% ) |
0.97 |
get Query-sorted |
6612 ops/sec (±0.34% ) |
6728 ops/sec (±0.97% ) |
1.02 |
setLong |
510 ops/sec (±0.31% ) |
489 ops/sec (±0.54% ) |
0.96 |
setLongWithMerge |
225 ops/sec (±0.29% ) |
218 ops/sec (±0.33% ) |
0.97 |
setLongWithSimpleMerge |
240 ops/sec (±0.48% ) |
235 ops/sec (±0.38% ) |
0.98 |
setSmallResponse 500x |
915 ops/sec (±0.24% ) |
809 ops/sec (±0.44% ) |
0.88 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3451 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 125 125
Lines 2241 2241
Branches 459 459
=======================================
Hits 2214 2214
Misses 13 13
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Motivation
Predictable names. Consistency with state.entities
Solution
Since this is a lookup table of all meta for every entity, we should make entity plural - just like we did for the entity table.