-
-
Notifications
You must be signed in to change notification settings - Fork 96
pkg: react-hooks-testing-library major #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Might have to consider forking or discontinuing use of this library as it doesn't seem to be maintained well. |
Size Change: +230 B (0%) Total Size: 109 kB
ℹ️ View Unchanged
|
dccd9f8
to
a863bbf
Compare
e1a60dd
to
4af71a3
Compare
491e650
to
cf0d343
Compare
69951c1
to
88eb783
Compare
@@ -46,7 +46,7 @@ | |||
"url": "https://github.com/coinbase/rest-hooks/issues" | |||
}, | |||
"dependencies": { | |||
"@testing-library/react-hooks": "~3.5.0" | |||
"@testing-library/react-hooks": "~5.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ~ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As outlined in a previous PR - there was an uncaught breaking change in a minor upgrade to this library. This lets us validate all minor upgrades before our users potentially get broken things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, gross
BREAKING CHANGE:
undefined
after suspense, rather thannull
(see https://github.com/testing-library/react-hooks-testing-library/releases/tag/v5.0.0)
Motivation
Keep up with the latest
Solution
Upgrade react-hooks-testing-library from 3.2 to 5
Had to change all the checks for suspense to undefined from null.
Deprecated
cleanup()
as it already happens on unmount.Added cleanup() to externalprovider in tests to reflect behavior of cacheprovider.
Updated redux docs to include calling manager's init
Waiting on testing-library/react-hooks-testing-library#554 to be able to use this version.