Skip to content

fix: Disallow breaking 3.6 version of @testing-library/react-hooks #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Jan 24, 2021

Motivation

3.6 accidentally introduced a breaking change. More here: testing-library/react-hooks-testing-library#554

Solution

Disallow major versions beyond 3.5.

@ntucker ntucker requested a review from ljharb January 24, 2021 21:27
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 109 kB

ℹ️ View Unchanged
Filename Size Change
packages/core/dist/index.cjs.js 12.5 kB 0 B
packages/core/dist/index.umd.min.js 5.73 kB 0 B
packages/endpoint/dist/index.cjs.js 1.64 kB 0 B
packages/endpoint/dist/index.umd.min.js 1.22 kB 0 B
packages/hooks/dist/index.cjs.js 714 B 0 B
packages/hooks/dist/index.umd.min.js 429 B 0 B
packages/legacy/dist/index.cjs.js 579 B 0 B
packages/legacy/dist/index.umd.min.js 511 B 0 B
packages/normalizr/dist/normalizr.amd.js 10.3 kB 0 B
packages/normalizr/dist/normalizr.amd.min.js 5.59 kB 0 B
packages/normalizr/dist/normalizr.browser.js 10.3 kB 0 B
packages/normalizr/dist/normalizr.browser.min.js 5.59 kB 0 B
packages/normalizr/dist/normalizr.js 10.1 kB 0 B
packages/normalizr/dist/normalizr.min.js 5.59 kB 0 B
packages/normalizr/dist/normalizr.umd.js 10.4 kB 0 B
packages/normalizr/dist/normalizr.umd.min.js 5.67 kB 0 B
packages/rest-hooks/dist/index.cjs.js 7.67 kB 0 B
packages/rest-hooks/dist/index.umd.min.js 4.08 kB 0 B
packages/rest/dist/index.cjs.js 3.88 kB 0 B
packages/rest/dist/index.umd.min.js 2.14 kB 0 B
packages/test/dist/index.cjs.js 2.77 kB 0 B
packages/use-enhanced-reducer/dist/index.cjs.js 1.08 kB 0 B
packages/use-enhanced-reducer/dist/index.umd.min.js 607 B 0 B

compressed-size-action

Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, this library (-‸ლ)

@ntucker ntucker merged commit b3b057b into master Jan 24, 2021
@ntucker ntucker deleted the fix/test-hooks-pkg branch January 24, 2021 21:32
@mpeyper

This comment has been minimized.

@ljharb

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants