Skip to content

Release channels translate #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 11, 2019

Conversation

mohamedsgap
Copy link
Contributor

@mohamedsgap mohamedsgap commented Dec 9, 2019

Translated Release Channels!

@mohamedsgap
Copy link
Contributor Author

Hey guys @asantarissy @iRayan7 @aladin002dz @Fcmam5 @mohshbool @3imed-jaberi @splimter I've just translated Release Channels, I need your reviews!

@netlify
Copy link

netlify bot commented Dec 9, 2019

Deploy preview for ar-reactjs ready!

Built with commit 988aa99

https://deploy-preview-205--ar-reactjs.netlify.com

Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

عملك ممتاز أخي، شكرا جزيلا لك على مساهتمك.
لديّ بعض التعليقات والاقتراحات راجعها لو سمحت 😄

@mohamedsgap
Copy link
Contributor Author

@Aissaoui-Ahmed @Fcmam5 please, check the latest changes!

Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @mohamedsgap , just one change to go!


#### Using the Next Channel for Integration Testing {#using-the-next-channel-for-integration-testing}
### استخدام القناة التالية فى اختبار التكامل {#using-the-next-channel-for-integration-testing}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### استخدام القناة التالية فى اختبار التكامل {#using-the-next-channel-for-integration-testing}
#### استخدام القناة التالية فى اختبار التكامل {#using-the-next-channel-for-integration-testing}

Copy link
Member

@Aissaoui-Ahmed Aissaoui-Ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove double space!

@mohamedsgap
Copy link
Contributor Author

made the latest changes as you @Fcmam5 @Aissaoui-Ahmed asked for!

Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for you @mohamedsgap ! 🚀

@Fcmam5 Fcmam5 removed the in-review label Dec 9, 2019
Copy link
Member

@Aissaoui-Ahmed Aissaoui-Ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one!

@mohamedsgap
Copy link
Contributor Author

@Aissaoui-Ahmed I've made the last change!

@asantarissy asantarissy self-requested a review December 11, 2019 04:15
@asantarissy asantarissy merged commit fa57a2d into reactjs:master Dec 11, 2019
@Aissaoui-Ahmed
Copy link
Member

LGTM great work @mohamedsgap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants