Skip to content

[DONE] translate <progress> page #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2023
Merged

[DONE] translate <progress> page #491

merged 3 commits into from
Jun 4, 2023

Conversation

mrlahmar
Copy link
Contributor

@mrlahmar mrlahmar commented Jun 3, 2023

No description provided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my commits

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @A7med3bdulBaset
Thank you for your commit, I appreciate it
I'm curios why you went for عرض instead of تصيير although in the glossary the translation for rendering is تصيير, is there any rule or special cases when I should use the first and when I should go for the second?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

على حسب السياق

@AhmedBaset AhmedBaset merged commit 74e664c into reactjs:main Jun 4, 2023
@AhmedBaset
Copy link
Collaborator

تم دمج الفرع
يمكنك اختيار صفحة أخرى الآن

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mrlahmar mrlahmar deleted the translate/progress branch June 5, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants