Done Translating-hooks-faq.md #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ar-reactjs ready! Built with commit 08b13d5 |
iRayan7
approved these changes
Apr 20, 2019
iRayan7
added
approved
changes-requested
work-in-progress
and removed
in-review
work-in-progress
approved
labels
iRayan7
requested changes
Apr 20, 2019
3imed-jaberi
added
in-review
and removed
changes-requested
update needed
Fcmam5
requested changes
Jul 30, 2019
There was a problem hiding this comment.
Really had a good time reading your translation! Thank you Soheyb.
I have some suggestions and some corrections to make, also:
- Please double check the code examples, some comments are not translated yet.
- Fix some formatting issues like some
** **are not rendered correctly, please check it when you run the documentation locally or on your deployed PR - Some chunks appeared to be added and not modified (like in line 370 and 450) did you have the last changes from the upstream branch before submitting this PR?
|
Going to Resolve Problems now !! |
splimter
force-pushed
the
Translating-hooks-faq.md
branch
from
f32b7b0 to
2ed236a
Compare
|
@splimter, please bro discuss with reviewers don't put the conversation in resolve mode .. |
3imed-jaberi
added
update needed
i will keep it in mind next time ... |
iRayan7
added
approved
and removed
update needed
iRayan7
approved these changes
Aug 8, 2019
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.