Skip to content

Shallow Rendering #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2019
Merged

Shallow Rendering #58

merged 7 commits into from
May 28, 2019

Conversation

tamarau
Copy link
Contributor

@tamarau tamarau commented May 25, 2019

Hi,

My first attempt to translate shallow rending.

I've got a couple of things I'm not too sure about so would like to ask for feedback here :)

  • I called shallow rendering 'Flaches Rendern'; rendern because I don't think there is a good German equivalent we use? I've seen 'Darstellung' but it's not what I would use when talking to other devs about rendering.
  • Not sure if I can leave 'unit tests' and 'high-level API' as they are? I marked them in italics for now until that is solved. :)
  • General question: how does the side menu get updated to the new title of the page?

Thanks ☺️

@netlify
Copy link

netlify bot commented May 25, 2019

Deploy preview for de-reactjs ready!

Built with commit 2946455

https://deploy-preview-58--de-reactjs.netlify.com

@ph1p ph1p self-requested a review May 27, 2019 08:12
@ph1p
Copy link
Member

ph1p commented May 27, 2019

Hi,

My first attempt to translate shallow rending.

I've got a couple of things I'm not too sure about so would like to ask for feedback here :)

  • I called shallow rendering 'Flaches Rendern'; rendern because I don't think there is a good German equivalent we use? I've seen 'Darstellung' but it's not what I would use when talking to other devs about rendering.

Hi Tamara!

First. Thanks for your PR ;)

Right now I think "Flaches Rendern" is ok. You have also added the English words so that everyone can understand them.

  • Not sure if I can leave 'unit tests' and 'high-level API' as they are? I marked them in italics for now until that is solved. :)

I changed "high level" to "übergeordnet". Might sound a bit better. Let me know what you think. "Unit Tests" is fine.

  • General question: how does the side menu get updated to the new title of the page?

Just update the nav.yml


I've made some suggestions. Feel free to comment or merge them ;)

@tamarau
Copy link
Contributor Author

tamarau commented May 27, 2019

Hi Phil,

Thanks for your feedback! Really appreciated :)

I've committed your changes and updated nav.yml. I also changed 'Output' in the last line to 'Ausgabe', so it matches the previous sentence.

@ph1p ph1p merged commit 8a289ad into reactjs:master May 28, 2019
@tamarau tamarau mentioned this pull request May 29, 2019
91 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants