Translate warning/don't call proptypes #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for de-reactjs ready! Built with commit 396fa21 |
ph1p
requested changes
Jul 23, 2019
| }; | ||
| } | ||
| ``` | ||
|
|
||
| This will silence the warning. | ||
| Das wird die Warnung stumm schalten. |
There was a problem hiding this comment.
Suggested change
| Das wird die Warnung stumm schalten. | |
| Das wird die Warnung stummschalten. |
ph1p
added
the
needs review from author
Co-Authored-By: Phil <[email protected]>
Co-Authored-By: Phil <[email protected]>
Co-Authored-By: Phil <[email protected]>
Co-Authored-By: Phil <[email protected]>
Co-Authored-By: Phil <[email protected]>
Co-Authored-By: Phil <[email protected]>
Co-Authored-By: Phil <[email protected]>
Co-Authored-By: Phil <[email protected]>
Co-Authored-By: Phil <[email protected]>
Co-Authored-By: Phil <[email protected]>
Co-Authored-By: Phil <[email protected]>
|
Thanks for reviewing! Looking back I made some very stupid mistakes (and you can tell I'm originally from Austria) 🤭 |
|
Oh sorry seems like I must have closed this by accident? I think it's ready to be merged to master |
ph1p
removed
the
needs review from author
ph1p
approved these changes
Aug 20, 2019
91 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my translation. :)
Wasn't sure if we translate 'fork'?