Skip to content

Change from reactjs.org to es.reactjs.org #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2019
Merged

Change from reactjs.org to es.reactjs.org #159

merged 1 commit into from
Feb 16, 2019

Conversation

loconluis
Copy link
Contributor

@loconluis loconluis commented Feb 16, 2019 •
edited
Loading

Ready for review.

I change reactjs.org links to es.reactjs.org

👇🏼👇🏼👇🏼👇🏼👇🏼👇🏼
#158 (comment)

  • package.json
  • site-constants.js
  • gatsby-config.js
  • MarkdownPage (the link href in "Edit this page") also I change Edit this page to Edita esta Página

And change lang es

  • Change html.js to have the attribute lang="es"

@dmoralesm @carburo @alejandronanez

alejandronanez
alejandronanez approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @loconluis for getting this done so fast.

@tesseralis tesseralis mentioned this pull request Feb 16, 2019
Closed
10 tasks
@alejandronanez alejandronanez merged commit 79e6cce into reactjs:master Feb 16, 2019
@loconluis loconluis deleted the from-react-to-esreact branch February 21, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandronanez alejandronanez alejandronanez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loconluis @alejandronanez