Skip to content

Translate Codebase Overview #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2019

Conversation

paramithatm
Copy link
Contributor

@paramithatm paramithatm commented Oct 30, 2019

Translated Codebase Overview page.
Please kindly review my work.
Thanks!

@netlify
Copy link

netlify bot commented Oct 30, 2019

Deploy preview for idreactjs ready!

Built with commit a6d3af3

https://deploy-preview-128--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Oct 30, 2019

Deploy preview for id-reactjs ready!

Built with commit a6d3af3

https://deploy-preview-128--id-reactjs.netlify.com

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good already @paramithatm! Just a few more little things and this is good to go:

@paramithatm paramithatm requested a review from resir014 November 11, 2019 14:01
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for your help!

@resir014 resir014 merged commit 5185383 into reactjs:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants