Skip to content

Translate Synthetic Event #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 10, 2019
Merged

Translate Synthetic Event #31

merged 20 commits into from
Jul 10, 2019

Conversation

devinryanriota
Copy link
Contributor

@devinryanriota devinryanriota commented Feb 17, 2019 •
edited
Loading

Hi, kindly check / comment on the translation. Thanks!

@netlify
Copy link

netlify bot commented Feb 17, 2019 •
edited
Loading

Deploy preview for idreactjs ready!

Built with commit 72360f7

https://deploy-preview-31--idreactjs.netlify.com

regalius
regalius requested changes Feb 24, 2019
View reviewed changes
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devinryanriota , Thanks for your contribution. So sorry I had a busy week and wasn't able to review your contribution, there's several changes that needs to be done and I need your point of view regarding the suggestions. 🎉

@devinryanriota
Copy link
Contributor Author

hi @regalius !
sure, I'll check the suggestions by today or tomorrow night ya, will come back to you soon!

@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for id-reactjs ready!

Built with commit 4be578a

https://deploy-preview-31--id-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 28, 2019 •
edited
Loading

Deploy preview for id-reactjs ready!

Built with commit 72360f7

https://deploy-preview-31--id-reactjs.netlify.com

@regalius
Copy link
Member

regalius commented Mar 3, 2019

since pointer event is not translated, I think that "focus event" translation should also be retained. wdyt @regalius ?

Agreed, for now I think it's a little bit weird to translate the event names, let's keep it that way so later when we find the need to translate the event names, we can do it accordingly 😄

@tesseralis tesseralis mentioned this pull request Mar 3, 2019
Closed
96 tasks
@devinryanriota
Copy link
Contributor Author

hi @regalius , looks like I'm finally done with the revision 😄 . sorry I'm kinda busy last week 😞

@gedeagas gedeagas removed their request for review April 12, 2019 12:33
grikomsn
grikomsn requested changes Jul 7, 2019
View reviewed changes
@grikomsn grikomsn requested a review from resir014 July 9, 2019 14:25
@resir014 resir014 merged commit 41b12c4 into reactjs:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regalius regalius regalius requested changes

@resir014 resir014 resir014 approved these changes

@grikomsn grikomsn grikomsn approved these changes

@arfianadam arfianadam Awaiting requested review from arfianadam

Assignees

@resir014 resir014

@grikomsn grikomsn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devinryanriota @regalius @resir014 @grikomsn