Skip to content

docs: translate Keeping Components Pure page #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 29, 2023

Conversation

samnap11
Copy link
Contributor

@samnap11 samnap11 commented Apr 27, 2023

This PR is created to translate Keeping Components Pure page to Indonesian.

Related to #330

Closes #435

Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need confirmation from the others. Also might have to be addressed in the Glossary later too.

@samnap11 samnap11 changed the title Keeping components pure docs: translate Keeping Components Pure page Apr 27, 2023
@samnap11 samnap11 force-pushed the keeping-components-pure branch from 67921a3 to 4ef6f3c Compare April 28, 2023 02:35
@samnap11 samnap11 marked this pull request as ready for review April 28, 2023 02:36
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to consider.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

github-actions bot commented Apr 29, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mhaidarhanif
Copy link
Collaborator

We'll also wait for either @mazipan @r17x @resir014 to approve.

Copy link
Collaborator

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor comments. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keeping Components Pure
5 participants