-
Notifications
You must be signed in to change notification settings - Fork 264
docs: translate API Reference -> react-dom
-> Client -> createRoot
#514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: translate API Reference -> react-dom
-> Client -> createRoot
#514
Conversation
Hi @resir014 / @zainfathoni, I've translated the page and this MR is ready for review. Tough, I still have questions:
Also note:
Thank you so much! |
1510b28
to
6e672b1
Compare
Yes, as discussed here, #337 (comment), we agreed to translate them.
Those are prevalent phrases recently in the frontend community. Translating them prematurely might lead to more confusion. Therefore, we can keep them as loan words but remember to italicize them.
I'm afraid I have to disagree. In PUEBI, we must italicize them while connecting the prefix and suffix with
Yes, please leave the error messages in the Troubleshooting part because that's what the readers will encounter while running the code and using React in the real world.
Thank you for your careful consideration and contribution! |
Hello @chez14, Do you need a help for this PRs? Thanks |
rect-dom/client
→ createRoot
to Bahasa Indonesiareact-dom
-> Client -> createRoot
Hi @r17x, Ah thank you for reaching back, I'm waiting for more feedback so I can edit them in one go. Should I just patch this, or... wait for other reviewer first? Thanks! |
@chez14 You can start working on any suggested changes now. We can come back and review it later. |
Hi @r17x, @resir014, and @zainfathoni, I have updated the PR as requested. Please let me know if you have any feedback or questions. Thank you! |
@zainfathoni @resir014 This PRs have been updated yet, need re-review. |
489623f
to
6f31c8d
Compare
@resir014 could you review this PR |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Closes #454
Description
Translate the
react-dom/client
→createRoot
page.Page URL:
References:
createRoot
#454+