Skip to content

docs: translate API Reference -> react-dom -> Client -> createRoot #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 6, 2023

Conversation

chez14
Copy link
Contributor

@chez14 chez14 commented Apr 30, 2023

Closes #454

Description

Translate the react-dom/clientcreateRoot page.
Page URL:

References:

@chez14
Copy link
Contributor Author

chez14 commented Apr 30, 2023

Hi @resir014 / @zainfathoni, I've translated the page and this MR is ready for review.

Tough, I still have questions:

  • I noticed that some titles such as "Parameters" and "Returns" are not translated in one of the Sepuh's MR, and I honestly feel like this can be translated properly as "Parameter" and "Pengembalian". Should we do that? (In current MR, I left it as is)

  • Should I translate following terms?

    • "server-side rendering (SSR)" → "Perenderan pada sisi server (server-side rendering, SSR)"
    • "static site generation (SSG)" → "Pembangunan situs statik (static site generation, SSG)"

    Currently I've left it as is and treat it as loan word (term?).

Also note:

  • I noticed that loanwords that have been 'glued' with imbuhan such as "merender" currently don't need to be italicized or separated with -, I applied this rule for "render", "unmount", "hydrate", "log".
  • I did not translate the error messages in the Troubleshooting part because I don't think error messages in React is localized too. Please let me know if this should actually be translated too.

Thank you so much!

@zainfathoni
Copy link
Collaborator

zainfathoni commented May 1, 2023

Hi @resir014 / @zainfathoni, I've translated the page and this MR is ready for review.

Tough, I still have questions:

  • I noticed that some titles such as "Parameters" and "Returns" are not translated in one of the Sepuh's MR, and I honestly feel like this can be translated properly as "Parameter" and "Pengembalian". Should we do that? (In current MR, I left it as is)

Yes, as discussed here, #337 (comment), we agreed to translate them.

  • Should I translate following terms?

    • "server-side rendering (SSR)" → "Perenderan pada sisi server (server-side rendering, SSR)"
    • "static site generation (SSG)" → "Pembangunan situs statik (static site generation, SSG)"

    Currently I've left it as is and treat it as loan word (term?).

Those are prevalent phrases recently in the frontend community. Translating them prematurely might lead to more confusion. Therefore, we can keep them as loan words but remember to italicize them.

Also note:

  • I noticed that loanwords that have been 'glued' with imbuhan such as "merender" currently don't need to be italicized or separated with -, I applied this rule for "render", "unmount", "hydrate", "log".

I'm afraid I have to disagree. In PUEBI, we must italicize them while connecting the prefix and suffix with -.

image

  • I did not translate the error messages in the Troubleshooting part because I don't think error messages in React is localized too. Please let me know if this should be translated too.

Yes, please leave the error messages in the Troubleshooting part because that's what the readers will encounter while running the code and using React in the real world.

Thank you so much!

Thank you for your careful consideration and contribution!
Please give us some time to review your PR. 😁 🙏

@r17x
Copy link
Collaborator

r17x commented Jun 28, 2023

Hello @chez14, Do you need a help for this PRs?

Thanks

@resir014 resir014 changed the title Translate rect-dom/clientcreateRoot to Bahasa Indonesia docs: translate API Reference -> react-dom -> Client -> createRoot Jun 29, 2023
@chez14
Copy link
Contributor Author

chez14 commented Jul 1, 2023

Hi @r17x,

Ah thank you for reaching back, I'm waiting for more feedback so I can edit them in one go.

Should I just patch this, or... wait for other reviewer first?

Thanks!

@resir014
Copy link
Member

resir014 commented Jul 1, 2023

@chez14 You can start working on any suggested changes now. We can come back and review it later.

@chez14
Copy link
Contributor Author

chez14 commented Jul 1, 2023

Hi @r17x, @resir014, and @zainfathoni,

I have updated the PR as requested.

Please let me know if you have any feedback or questions. Thank you!

@r17x
Copy link
Collaborator

r17x commented Jul 2, 2023

@zainfathoni @resir014 This PRs have been updated yet, need re-review.

@r17x r17x force-pushed the chez14/translate-react-dom-createroot branch from 489623f to 6f31c8d Compare July 6, 2023 07:00
@r17x
Copy link
Collaborator

r17x commented Jul 6, 2023

@resir014 could you review this PR

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.01 KB (🟢 -40 B) 179.16 KB
/500 76 KB (🟢 -40 B) 179.16 KB
/[[...markdownPath]] 77.45 KB (🟢 -82 B) 180.6 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@resir014 resir014 merged commit 1e503ee into reactjs:main Jul 6, 2023
@chez14 chez14 deleted the chez14/translate-react-dom-createroot branch July 30, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createRoot
4 participants