Skip to content

docs: translate API Reference -> react-dom -> hydrate #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 13, 2023
Merged

docs: translate API Reference -> react-dom -> hydrate #528

merged 14 commits into from
Jul 13, 2023

Conversation

zakirkun
Copy link
Contributor

@zakirkun zakirkun commented May 1, 2023

Closes #440

Description

continue translating the hydrate page from pr #508
Page URL: https://id.react.dev/reference/react-dom/hydrate

@zakirkun zakirkun marked this pull request as ready for review May 1, 2023 12:14
@r17x
Copy link
Collaborator

r17x commented May 1, 2023 •
edited
Loading

This PRs (but still in draft & didn't have any progress) #508 is same Issue #440 , what do you think @zainfathoni @mhaidarhanif @resir014

r17x
r17x requested changes May 1, 2023
View reviewed changes
@zainfathoni
Copy link
Collaborator

zainfathoni commented May 1, 2023 •
edited
Loading

This PRs (but still in draft & didn't have any progress) #508 is same Issue #440 , what do you think @zainfathoni @mhaidarhanif @resir014

We should prioritize the one with further progress and closer to completion especially when the previous PR has been stagnating for a while (two days or more).

zakirkun
zakirkun commented May 1, 2023
View reviewed changes
Copy link
Contributor Author

@zakirkun zakirkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected the typo

@zakirkun zakirkun requested a review from r17x May 1, 2023 12:47
r17x
r17x requested changes May 1, 2023
View reviewed changes
@zakirkun zakirkun requested a review from r17x May 1, 2023 12:57
r17x
r17x requested changes May 1, 2023
View reviewed changes
@zakirkun zakirkun requested a review from r17x May 1, 2023 13:34
@github-actions
Copy link

github-actions bot commented May 1, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

r17x
r17x requested changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free re-check for same word or case for changes!

@zakirkun zakirkun requested a review from r17x May 1, 2023 14:16
zainfathoni
zainfathoni requested changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@zainfathoni zainfathoni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggestions to introduce new terms into the glossary, @resir014 @r17x @mhaidarhanif @mazipan

English Indonesian
hydration hidrasi
hydrate hydrate (as a function name)
hydrate menghidrasi (as a verb)
hydrating menghidrasi

Let's discuss them here: #337 (comment)

@zakirkun zakirkun requested a review from zainfathoni May 1, 2023 14:55
@r17x r17x force-pushed the docs/translation/hydrate branch from 2e24e82 to 20ef3df Compare May 6, 2023 16:30
@r17x
Copy link
Collaborator

r17x commented May 7, 2023

Need to re-check @zainfathoni

@r17x
Copy link
Collaborator

r17x commented May 15, 2023

need to re-review @zainfathoni

resir014
resir014 requested changes May 26, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change. @zakirkun

@resir014 resir014 changed the title refactor(hydrate.md): init translate from english to indonesia docs: translate react-dom hydrate reference May 26, 2023
@mhaidarhanif
Copy link
Collaborator

@zakirkun need to resolve the requests from @resir014 and @zainfathoni

@mhaidarhanif
Copy link
Collaborator

Once @zakirkun resolved the issues, then @resir014 and @zainfathoni will approve

@resir014
Copy link
Member

Taking over this PR since it's been stale for a month.

resir014
resir014 reviewed Jul 12, 2023
View reviewed changes
@resir014 resir014 changed the title docs: translate react-dom hydrate reference docs: translate API Reference -> react-dom -> hydrate Jul 12, 2023
@resir014 resir014 dismissed zainfathoni’s stale review July 12, 2023 08:01

Requested changes were made and co-approved.

@resir014 resir014 merged commit dcb7bad into reactjs:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resir014 resir014 resir014 approved these changes

@mazipan mazipan mazipan approved these changes

@r17x r17x r17x approved these changes

@mhaidarhanif mhaidarhanif Awaiting requested review from mhaidarhanif

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hydrate
6 participants
@zakirkun @r17x @zainfathoni @mhaidarhanif @resir014 @mazipan