Skip to content

docs: translate API Reference -> Legacy -> findDOMNode #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 1, 2023
Merged

docs: translate API Reference -> Legacy -> findDOMNode #599

merged 7 commits into from
Aug 1, 2023

Conversation

chez14
Copy link
Contributor

@chez14 chez14 commented Jul 30, 2023 •
edited
Loading

Fixes #439 and closes #510

Description

This PR adds translation to findDOMNode page, continuing @afrianjunior's effort.

Translate the findDOMNode page.
Page URL:

@chez14 chez14 changed the title Chez14/translate find dom node docs: Translate findDOMNode Jul 30, 2023
@github-actions
Copy link

github-actions bot commented Jul 30, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@chez14 chez14 force-pushed the chez14/translate-findDOMNode branch from c0583b1 to acb6416 Compare July 30, 2023 10:52
@chez14
Copy link
Contributor Author

chez14 commented Jul 30, 2023

Hi @resir014 & @zainfathoni,

I have translated the findDOMNode page, can you please review this PR?

Please let me know if you have any questions or feedback. Thank you!

resir014
resir014 reviewed Jul 30, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass for review. @chez14

@chez14
Copy link
Contributor Author

chez14 commented Jul 30, 2023

Hi @resir014,

I have patched this PR as requested, can you please review again? Thank you!

@chez14 chez14 requested a review from resir014 July 30, 2023 11:37
resir014
resir014 reviewed Jul 30, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass of review. @chez14

@chez14
Copy link
Contributor Author

chez14 commented Jul 30, 2023 •
edited
Loading

Hi @resir014,

I have updated the PR as requested (and applicable feedback from other PR as well), can you please review again?

Thank you!

@chez14 chez14 requested a review from resir014 July 30, 2023 14:46
resir014
resir014 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks!

@resir014 resir014 changed the title docs: Translate findDOMNode docs: translate API Reference -> Legacy -> findDOMNode Aug 1, 2023
@resir014 resir014 merged commit f84ba04 into reactjs:main Aug 1, 2023
@chez14 chez14 deleted the chez14/translate-findDOMNode branch August 2, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resir014 resir014 resir014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

findDOMNode
3 participants
@chez14 @resir014 @afrianjunior