Skip to content

Translation for the page 'Create a New React App' #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2019
Merged

Translation for the page 'Create a New React App' #143

merged 5 commits into from
Apr 12, 2019

Conversation

LucaBlackDragon
Copy link
Collaborator

Closes #41

@netlify
Copy link

netlify bot commented Mar 29, 2019 •
edited
Loading

Deploy preview for it-react-org ready!

Built with commit 5f3a003

https://deploy-preview-143--it-react-org.netlify.com

@LucaBlackDragon LucaBlackDragon changed the title Inizio traduzione Translation for the page 'Create a New React App' Mar 29, 2019
@netlify
Copy link

netlify bot commented Mar 29, 2019 •
edited
Loading

Deploy preview for it-reactjs ready!

Built with commit 5f3a003

https://deploy-preview-143--it-reactjs.netlify.com

@LucaBlackDragon LucaBlackDragon added needs +1 Needs an approval before merging (not from the author) ✔ translated and removed 🏗️ Work in progress Work in progress labels Mar 29, 2019
deblasis
deblasis requested changes Apr 7, 2019
View reviewed changes
content/docs/create-a-new-react-app.md Outdated

Don't forget to ensure your custom toolchain [is correctly set up for production](/docs/optimizing-performance.html#use-the-production-build).
Non ti dimenticare di assicurarti che la tua toolchain personalizzata [sia impostata correttamente per la produzione](/docs/optimizing-performance.html#use-the-production-build).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Non ti dimenticare di assicurarti che la tua toolchain personalizzata [sia impostata correttamente per la produzione](/docs/optimizing-performance.html#use-the-production-build).
Non dimenticare di assicurarti che la tua toolchain personalizzata [sia impostata correttamente per la produzione](/docs/optimizing-performance.html#use-the-production-build).

I found just this tiny grammar typo! 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alessandro, actually the "ti" is already included in "assicurar... ti".
If you think it's better, we could go for "Non ti dimenticare di controllare che la tua toolchain..."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Luca! Sorry for the delay. Yeah, the point is that we should have one "ti" not two. I like your suggestion even more actually:
"Non ti dimenticare di controllare che la tua toolchain...."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confused the correction and the original translation 🤦‍♂️
Anyway, fixed! THANKS!!!

@deblasis deblasis merged commit b6fad02 into master Apr 12, 2019
@deblasis deblasis removed 🤓 in review needs +1 Needs an approval before merging (not from the author) labels Apr 12, 2019
@LucaBlackDragon LucaBlackDragon deleted the create-a-new-react-app branch August 17, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deblasis deblasis deblasis approved these changes

@lssmn lssmn Awaiting requested review from lssmn

Assignees
No one assigned
Labels
✔ translated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation for the page 'Installation -> Create a New React App'
2 participants
@LucaBlackDragon @deblasis