Skip to content

Use singular 'ref' and 'key' #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented Feb 5, 2019

用語集の見出し項目などの refs と keys を単数形に変えました。props は複数の項目の集合として扱うのが当たり前という感じなのでいいですが、ref や key はそうではないので。hooks なども日本語の解説文の中では hook で揃えるべきだと思います。

@potato4d @koba04 さくっとご確認お願いします

@smikitky smikitky requested review from potato4d and koba04 February 5, 2019 17:12
@koba04
Copy link
Member

koba04 commented Feb 6, 2019

@smikitky refは単数かつ原文に関わらず小文字表記で統一しますか? #52 に大きな影響がありそうですね。

@smikitky
Copy link
Member Author

smikitky commented Feb 6, 2019

とりあえず単数形で統一、のところまではいいと思います。

見出しに英語がある時 (## Foo Bar) や文が英語から始まる時の大文字小文字については、現状あまり厳密に統一されていないですが、当面そんな致命的な話でもないのでこの件とは別に考えるということで如何でしょうか…

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです

@potato4d potato4d merged commit 1878273 into master Feb 7, 2019
@potato4d potato4d deleted the fix/glossary-singular-ref-key branch February 7, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants