Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

[fixed] maybeScrollItemIntoView exception when itemNode is not found #281

Closed
wants to merge 2 commits into from

Conversation

faviktor92
Copy link

No description provided.

@CMTegner
Copy link
Collaborator

It's difficult to know why you want to perform this change, since you've provided no context, but I'm assuming it's because you've implemented a renderMenu function which doesn't always return every item to be rendered. This edge case is already documented:

Ensure the returned tree includes every entry in items or else the highlight order and keyboard navigation logic will break.

@CMTegner CMTegner closed this Nov 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants