Add feature for SVG attributes conversion #136
Conversation
|
Any chance of this getting merged soon ? |
|
Hi @ritz078 . If you are in a hurry, htmltojsx that corresponds to SVG is released in Scoped Package, so please try using it 😃 |
|
Sorry, I completely missed this... I'll take a look soon! |
|
Hi @Daniel15, Thanks ! |
|
Thanks @tsuyoshiwada . FYI I am using it on https://transform.now.sh/html-to-jsx |
| } | ||
| output.push(this.toJSXKey(key) + ': ' + this.toJSXValue(this.styles[key])); | ||
| } | ||
| eachObj(this.styles, function(key, value) { |
There was a problem hiding this comment.
What's the purpose of this change?
There was a problem hiding this comment.
We have refactored the iteration of the object using the newly created eachObj helper.
I'm sorry I made a confusing change... 😢
There was a problem hiding this comment.
It's totally fine, don't worry @tsuyoshiwada 😄 I was just wondering about why we couldn't just continue to use a regular for loop here.
There was a problem hiding this comment.
Thank you! It was worried whether it became a meddle, but I am relieved 😃
|
Released as 0.3.0 😃 |
|
Hi @Daniel15, Thank you 😄 I checked that I was working. |
Hi, Thank you for useful library 😃
I wanted to convert the attributes of SVG like #135.
However, when I actually convert it I got the following output.
So we added
SVGDOMPropertyConfigas an attribute mapping target as well asHTMLDOMPropertyConfig.Related issues