Switch to jsdom no contextify

[alansouzati]

Hi guys,

This PR aims to switch from jsdom to jsdom-no-contextify. jsdom version 4.4.x does not support Node 10, and jsdom 3.1.x has dependencies with contextify. Contextify has native build that requires Python.

As a result, I believe it makes sense to move to jsdom-no-contextify. I tried running the build with react-magic and everything seems to be working fine.

Alan

[alansouzati]

Hi guys, I guess everything is looking ok here. Would appreciate any feedback as our team is looking for supporting Node 10. 👍

[Daniel15]

I'm on vacation from 2nd July until 12th July with limited internet access.
I'll take a look at this once I'm back.

Sent from my mobile.
On Jul 2, 2015 8:11 AM, "Alan Souza" [email protected] wrote:

Hi guys, I guess everything is looking ok here. Would appreciate any
feedback as our team is looking for supporting Node 10. [image: 👍]

—
Reply to this email directly or view it on GitHub
#29 (comment).

[alansouzati]

Hey @Daniel15 any news here?

[Daniel15]

Sorry for the delay!

[alansouzati]

Great news @Daniel15 ! Thanks for working on that. Could you please release a new version on NPM that includes this fix? 👍

[Daniel15]

Oops, I thought I did that when I merged this, but I must have gotten distracted 😄 Pushed 0.2.3 now, thanks for the reminder.

[alansouzati]

No problem at all. thanks ;)