Handle braces in text. #45
Conversation
|
@solugebefola updated the pull request. |
Allow for conversion to `module.exports` rather than `React.createClass` using option `e`. Or no wrapper at all with option `g`
|
@solugebefola updated the pull request. |
`e` for `module.exports` wrapper and `g` for no wrapper, when grouping files.
|
@solugebefola updated the pull request. |
| @@ -13,6 +13,10 @@ function getArgs() { | |||
| ) | |||
| .describe('className', 'Create a React component (wraps JSX in React.createClass call)') | |||
| .alias('className', 'c') | |||
| .boolean('e') | |||
| .describe('e', 'Decide whether to wrap in module.exports') | |||
There was a problem hiding this comment.
This option seems useful, but it's not really relevant to this pull request. Could you please split it out into a separate one? I think because you created this pull request off your master branch, Github is including all the changes on your master branch. You should make a separate branch with just the changes you want to submit :)
There was a problem hiding this comment.
Cheers, I resubmitted the braces change in a separate PR. The other changes are submitted as before. I was not sure how to break the second set of changes into it's own PR without dependence on the earlier commits, so I left it alone.
|
Looks like this was resubmitted as #55 |
ghost
added
the
This is a fix to handle braces written in the text. It simply surrounds them with
{'..'}which is the same method by which braces are handled inside ofpretags. It was written in response to #42 . @Daniel15, I assume this is the sort of thing that will work?