Skip to content

[fixed]: css class added to root document instead of modal ownerDocument #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022
Merged

[fixed]: css class added to root document instead of modal ownerDocument #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,15 @@ import ReactModal from 'react-modal';

bodyOpenClassName={
"ReactModal__Body--open"
/* String className to be applied to the document.body
/* String className to be applied to the modal ownerDocument.body
(must be a constant string).
This attribute when set as `null` doesn't add any class
to document.body.
See the `Styles` section for more details. */}

htmlOpenClassName={
"ReactModal__Html--open"
/* String className to be applied to the document.html
/* String className to be applied to the modal ownerDocument.html
(must be a constant string).
This attribute is `null` by default.
See the `Styles` section for more details. */}
Expand Down
22 changes: 16 additions & 6 deletions src/components/ModalPortal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export default class ModalPortal extends Component {
}),
className: PropTypes.oneOfType([PropTypes.string, PropTypes.object]),
overlayClassName: PropTypes.oneOfType([PropTypes.string, PropTypes.object]),
parentSelector: PropTypes.func,
bodyOpenClassName: PropTypes.string,
htmlOpenClassName: PropTypes.string,
ariaHideApp: PropTypes.bool,
Expand Down Expand Up @@ -149,15 +150,19 @@ export default class ModalPortal extends Component {
appElement,
ariaHideApp,
htmlOpenClassName,
bodyOpenClassName
bodyOpenClassName,
parentSelector
} = this.props;

const parentDocument =
(parentSelector && parentSelector().ownerDocument) || document;

// Add classes.
bodyOpenClassName && classList.add(document.body, bodyOpenClassName);
bodyOpenClassName && classList.add(parentDocument.body, bodyOpenClassName);

htmlOpenClassName &&
classList.add(
document.getElementsByTagName("html")[0],
parentDocument.getElementsByTagName("html")[0],
htmlOpenClassName
);

Expand All @@ -174,15 +179,20 @@ export default class ModalPortal extends Component {
appElement,
ariaHideApp,
htmlOpenClassName,
bodyOpenClassName
bodyOpenClassName,
parentSelector
} = this.props;

const parentDocument =
(parentSelector && parentSelector().ownerDocument) || document;

// Remove classes.
bodyOpenClassName && classList.remove(document.body, bodyOpenClassName);
bodyOpenClassName &&
classList.remove(parentDocument.body, bodyOpenClassName);

htmlOpenClassName &&
classList.remove(
document.getElementsByTagName("html")[0],
parentDocument.getElementsByTagName("html")[0],
htmlOpenClassName
);

Expand Down