Components are not unmounted when navigating back

[meleyal]

Components on the current page are not unmounted when navigating to a page cached by Turbolinks (e.g. back button).

Events for an initial page load:

1. page:change <-- components are mounted

Events for a normal page visit (e.g. clicking a link):

1. page:before-change <-- components are unmounted here...
2. page:fetch
3. page:receive <-- ...or here with When using turbolinks, unmount components just before loading the new page #85
4. page:change <-- components are mounted
5. page:load

Events for a cached page (e.g. back button):

1. page:change <-- components are mounted
2. page:restore

As you can see, neither of the unmount events are fired for cached pages.

My initial though was to unmount on page:change and mount on both page:load and page:restore, but this obviously won't work for the initial page load.

The only solution I can currently think of is to turn off Turbolinks caching via Turbolinks.pagesCached(0)

[rmosolgo]

geez, this stinks. I see it too. thanks for sharing your workaround.

[zpao]

Do we want to force that off or should we just make it big and bold in the readme?

[rmosolgo]

Shucks, it would be nice to make it Just Work ^TM but that doesn't really seem possible with what we've got.

I'm in favor of setting Turbolinks.pagesCached(0) (and saying so in the readme) to save people from nasty bugs. (That's what happened to me -- I still had flux-y changeListeners attached even after page change 😞)

[rmosolgo]

Looks like we fished our wish -- the next version of Turbolinks will have page:before-unload events 😀

[meleyal]

nice work @rmosolgo

[zpao]

👍