Skip to content

Fix a documentation typo and several small proofing edits #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

christopherstyles
Copy link
Contributor

There’s a typo in VERSIONS.md and a few small spots where the documentation can be a bit more consistent with colon usage and inline code spans (when referring to react-rails etc). Nothing major at all, just some tiny things I noticed 😉

There is a typo in `VERSIONS.md` and a few small spots where the
documentation can be a bit more consistent with colon usage and
inline code spans (when referring to `react-rails` etc). Nothing
major at all, just some tiny things I noticed 😉
@rmosolgo
Copy link
Member

rmosolgo commented Apr 7, 2015

👍 for proper parallel structure!

@christopherstyles
Copy link
Contributor Author

@rmosolgo anything I need to do to get this passing?

It’s throwing ActionView::Template::Error: TypeError: Cannot set property 'root' of null – maybe the jashkenas/coffeescript#3829 issue again?

@rmosolgo
Copy link
Member

Yes, that's the issue, sadly nothing to do that I know of!

rmosolgo pushed a commit that referenced this pull request Apr 21, 2015
…edits

Fix a documentation typo and several small proofing edits
@rmosolgo rmosolgo merged commit 39cc583 into reactjs:master Apr 21, 2015
@rmosolgo
Copy link
Member

thanks!

@christopherstyles christopherstyles deleted the cs-small-proofreading-edits branch April 21, 2015 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants