Fix Rails 5 .to_prepare deprecation warning #526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In rails/rails@d3c9d80,
ActionDispatch::Reloader.to_prepare
(and friends) were moved toActiveSupport
.For now, they're only issuing a deprecation warning, but they're planning on dropping support in Rails 5.1.
Testing
I didn't have a great way to add a test for this, but the implementation seems pretty straightforward. I've tested that the gem works with an app in development. The app doesn't actually use server rendering, but it does boot and otherwise work great.