Bind to Turbolinks or native load/unload events, not both #69
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw the same error locally when running the tests, but only intermittently. I think this is unrelated to the patch. |
|
The failing tests seem to be related to #59 |
|
@JakubMal tests are now passing |
|
👍 Let's do it :) |
zpao
added a commit
that referenced
this pull request
Sep 7, 2014
Bind to Turbolinks or native load/unload events, not both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v2.0.0 Turbolinks fires the
page:changeevent onDOMContentLoaded.This was causing components rendered via
react_ujsto be initialized twice, once onDOMContentLoaded, then again when Turbolinks fires its event.