This repository was archived by the owner on Oct 26, 2018. It is now read-only.
Don't navigate immediately on boot. #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an issue in my app, in combination with
react-fetcher
, whereredux-simple-router
would create a history navigation on load, even though there's no reason to immediately navigate right on boot (the url is already in the URL bar).Was this behavior intentional? Changing this line fixed the issue for me and I no longer have a redundant
UPDATE_PATH
on boot and an additional fetch.If it helps, I'm pairing this with populating
state.routing.path
on the server side usingreq.url
, so the routing path is correctly pre-populated on boot.