Skip to content

Improve documentation for input type=file #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bvaughn opened this issue Oct 8, 2017 · 3 comments
Closed

Improve documentation for input type=file #86

bvaughn opened this issue Oct 8, 2017 · 3 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

This issue was originally reported by @kevinsimper via facebook/react/issues/3981

Nowhere on the react documentation is there a reference on how to handle <input type="file"/>

It is a speciel field that can not be serialized, and I think it deserve some kind of mention, maybe just a link to some other resource or if it is just like a normal input, just saying that.

I think it might be worth mentioning eg you can't actually programmatically set the value of a file input which is a pretty big deal- it means you're more susceptible to issues with reconciliation. You can only read. You also have to read from node.files which is just how those work even outside React, but still might be worth mentioning.

@vishalvrv9
Copy link
Contributor

Hello is this issue still open and can I take this up? This is referenced to issue#218 (which is also open)
Sorry I am a little lost (new to open source contributions) but I think I can do this. Thanks.

@bvaughn
Copy link
Contributor Author

bvaughn commented Nov 21, 2017

This issue is all yours, @vishalvrv9! 😄

I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 2, 2018

Resolved via #323

Thanks @vishalvrv9 !

@bvaughn bvaughn closed this as completed Jan 2, 2018
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
Adiciona os termos "event handler" e "event listener" para o Glossário.

Verifiquei que no MDN esses termos são traduzidos:

Original | Tradução
---|---
event listener | escutador de eventos
event handler | manipulador de eventos

Fonte: https://developer.mozilla.org/pt-BR/docs/Aprender/JavaScript/Elementos_construtivos/Events

Porém, acho estranho. Não sei se é porque estou acostumado com os termos em inglês.

Gostaria da opinião de mais pessoas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants