Add info to Children.toArray docs about invalid elements #1127
Conversation
This adds to the `React.Children.toArray` documentation to mention that it will filter out invalid elements. I needed to filter out invalid child elements in an application I am working on. When searching for the best appraoch, I came across an old github issue facebook/react#2956, and found that the discussion led to the creation of `React.Children.toArray`. I didn't realize that `toArray` would do this, even after reading the docs for it, and thought it would be worthwhile to include for the next developer looking for it.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Deploy preview for reactjs ready! Built with commit 9b680fb |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
+1 - Please merge this in. It takes an inordinate amount of time in parsing github issues and test cases to figure out that |
|
Hello @AEgan, thank you for taking the time to contribute! |
|
@BartoszKlonowski I completely forgot about this! looks like the caveat is included in the updated docs
Thanks for the reminder, I'll close out this PR |
This adds to the
React.Children.toArraydocumentation to mention that it will filter out invalid elements.I needed to filter out invalid child elements in an application I am working on. When searching for the best approach, I came across an old github issue facebook/react#2956, and found that the discussion led to the creation of
React.Children.toArray. I didn't realize thattoArraywould do this, even after reading the docs for it. I thought it would be helpful to add, so I decided to open a PR. Feel free to suggest any changes to the wording, or close if you think it's not necessary.