gatsby-remark-code-repls-modification #455
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit b76ec15 |
|
@bvaughn Can't figure out what went wrong with circleCI tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in continuation to #323
Have added the required code in the
examplesdirectory which goes by the nameinput-type-file.jsand pointed it to codepen using the gatsby-remark-code-repls plugin.As you would notice, I created a new branch and submitted a PR. Since I'm new to this, I was curious if it is a good practice to create a new branch every time one wants to submit a PR or should I just have pushed the changes in the previous branch? 🤔