Skip to content

[Beta] Top bar fixes #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2022
Merged

[Beta] Top bar fixes #5025

merged 1 commit into from
Sep 9, 2022

Conversation

gaearon
Copy link
Member

@gaearon gaearon commented Sep 9, 2022

  • Makes the banner desktop-only. The link didn't work on mobile anyway, and it doesn't look we're going to get this fixed. Closes “Support Ukraine 🇺🇦“ link doesn’t work on mobile #4524.
  • On mobile, the top navigation bar fixed rather than sticky. This fixes issues caused by position: sticky in Safari iOS on navigation. Previously, the whole navigation bar would "blink" or disappear entirely when you navigate forward and backward. On desktop, keep it sticky.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 84.33 KB (🟡 +14 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 43.61 KB (🟡 +61 B) 127.94 KB
/500 43.59 KB (🟡 +61 B) 127.92 KB
/[[...markdownPath]] 43.68 KB (🟡 +61 B) 128 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

“Support Ukraine 🇺🇦“ link doesn’t work on mobile
2 participants