Skip to content

Move the section on file inputs to avoid circular learning dependency #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

gaearon
Copy link
Member

@gaearon gaearon commented Feb 5, 2018

Fixes #586 by moving the section into "uncontrolled components".

We could have also changed the example to have an onChange handler in the input and get it from event.target. Or read it via DOM from the form. But I kinda feel like this is the most flexible way people who need this will want to learn anyway.

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit 8f9c0d3

https://deploy-preview-588--reactjs.netlify.com

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan.

@gaearon gaearon merged commit 3ed5a51 into reactjs:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants