Skip to content

Conversation

wlwl2
Copy link
Contributor

@wlwl2 wlwl2 commented Mar 27, 2018

Added more notes on JSX comments in reactjs.

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@reactjs-bot
Copy link

reactjs-bot commented Mar 27, 2018

Deploy preview for reactjs ready!

Built with commit 8c79709

https://deploy-preview-714--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Collaborator

@alexkrolick alexkrolick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, {name} should not be in the comment block

@wlwl2
Copy link
Contributor Author

wlwl2 commented Mar 28, 2018

Hello, {name} should not be in the comment block

Purpose was to show that you could do that. Am I missing something here?

@alexkrolick
Copy link
Collaborator

alexkrolick commented Mar 28, 2018

You can demonstrate multiline comments without commenting out the code itself:

<div>
  {/* It also works 
  for multi-line comments. */}
  Hello, {name}!
</div>

@wlwl2
Copy link
Contributor Author

wlwl2 commented Mar 29, 2018

@alexkrolick Alright, I made the change.

@alexkrolick alexkrolick merged commit eb60d5a into reactjs:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants