Skip to content

feat: translate to lifecycle-of-reactive-effects pages #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2023
Merged

feat: translate to lifecycle-of-reactive-effects pages #490

merged 2 commits into from
Sep 7, 2023

Conversation

burakcihan61
Copy link
Contributor

No description provided.

alioguzhan
alioguzhan requested changes Sep 5, 2023
View reviewed changes
Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect -> Efekt
Effects -> Efektler

seklinde ceviriyi guncellersek sonrasinda merge edebiliriz.

src/content/learn/lifecycle-of-reactive-effects.md Outdated
@@ -1,23 +1,23 @@
---
title: 'Lifecycle of Reactive Effects'
title: 'Reaktif Effects Yaşam Döngüsü'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reacktif Efektlerin Yaşam Döngüsü

daha dogru bir ceviri olabilir. Burada da asagida da effect kelimesini cevirebiliriz.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burada effect kullanmamım sebebi, çeviri kurallarında yazan ortak çeviriler.
https://github.com/reactjs/tr.react.dev/blob/main/TRANSLATION.md
Tekrar düzenleyip gönderiyorum.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haklisiniz. Ozur dilerim. 2021 yilinda oyle bir karar almisiz. Ben de hatirlamiyordum. Hatta direkt ben dahil olmusum olaya surada: #300

O karari almamiza sebep olan ceviride ozel olarak hook olan efektlerden bahsediliyordu sanirim. Google aramalarinda cikmasi icin oyle tutalim demistik.

Ama bugun bakinca cevirmek daha mantikli geldi. Bir de buradaki ceviride daha cok konseptin aciklanmasi soz konusu hooklardan ziyade. TRANSLATION.md dosyasini da guncelledim. Diger dillere de baktigimda genelde arkadaslar cevirmisler effect kelimesini.

alioguzhan
alioguzhan approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elinize saglik. Merge ediyorum.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@alioguzhan alioguzhan merged commit fee5b3f into reactjs:main Sep 7, 2023
@alioguzhan alioguzhan mentioned this pull request Sep 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alioguzhan alioguzhan alioguzhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burakcihan61 @alioguzhan