Skip to content

Remove duplicate code & make code reusable #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove duplicate code & make code reusable #244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f422d1
make code reusable
Foysal50x Feb 19, 2022
b26a12c
remove .idea files
Foysal50x Feb 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/Timer/Timers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,7 @@ public function cancel(TimerInterface $timer)
public function getFirst()
{
// ensure timers are sorted to simply accessing next (first) one
if (!$this->sorted) {
$this->sorted = true;
\asort($this->schedule);
}
$this->ensureTimerAreSorted();

return \reset($this->schedule);
}
Expand All @@ -74,10 +71,7 @@ public function isEmpty()
public function tick()
{
// ensure timers are sorted so we can execute in order
if (!$this->sorted) {
$this->sorted = true;
\asort($this->schedule);
}
$this->ensureTimerAreSorted();

$time = $this->updateTime();

Expand All @@ -104,4 +98,12 @@ public function tick()
}
}
}

private function ensureTimerAreSorted()
{
if (!$this->sorted) {
$this->sorted = true;
\asort($this->schedule);
}
}
}