Add support for pecl-ev #83
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for pecl-ev extension.
Add support for pecl-ev.
|
Uh, yeah, I guess I should have checked better before making the pull request. I suppose this one should be closed as the older pull requests do the same thing. I guess the differences are this one uses the default Ev loop instead of a new EvLoop, & it uses EvTimer for the periodic timer instead of EvPeriodic. EvPeriodic uses wall clock whereas EvTimer uses real time. Fewer lines of code? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the pecl-ev PHP extension.
https://bitbucket.org/osmanov/pecl-ev
http://docs.php.net/ev
I have it running locally & it seems to be working fine, as well as or better than the StreamSelectLoop. Poking & prodding is welcome of course.