Improve test suite to skip memory tests when lowering memory limit does not work #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
approved these changes
Feb 4, 2022
SimonFrings
approved these changes
Feb 4, 2022
WyriHaximus
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple changeset updates the test suite to skip memory tests when lowering memory limit does not work. This only affects the test suite and is a bit harder to reproduce in this repository itself, but I've stumbled over this while updating ReactPHP's combined test suite that runs all tests of all components and happens to use a few bytes more than the current limit.
I'll link the downstream PR against this one, a failed test run can be seen here: https://github.com/clue-labs/reactphp/runs/5063358894?check_suite_focus=true#step:5:54