Skip to content

Conversation

mickael-menu
Copy link
Member

We have incorrect RWP manifest and packages in the wild:

  • missing a self link in a manifest,
  • with percent-decoded paths instead of valid URL in Link objects' href.

This PR relaxes the checking rules to avoid breaking backward compatibility.

Note that there is an ambiguity with percent-decoded paths. We favor valid href first (valid percent-encoded URL) and fallback on a percent-decoded path only if it fails.

@mickael-menu mickael-menu requested a review from qnga October 6, 2023 09:55
@mickael-menu mickael-menu requested a review from qnga October 12, 2023 08:49
@mickael-menu mickael-menu merged commit d8c3cd2 into v3 Oct 12, 2023
@mickael-menu mickael-menu deleted the fix/rwpm-strict branch October 12, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants