Fix 16K support for PDFium #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnga
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #638, #709
This PR fix the 16K support issue with readium using the forks of marain87
Pdfium Android fork
AndroidPdfViewer fork
These are compatible with each other and are both published on jitpack.
I have verified that PDFs are working in the test app on a 16k emulator without any warning messages about 16k compatibility. I have also built a version of the readium-toolkit library locally and tested it in our production apps, both with and without LCP and have not run into any issues.
As
:readium:adapters:pdfium:readium-adapter-pdfium-commononly acted as an umbrella for the locally included Pdfium lib, I removed it and replaced the references with a dependency directly on the new remote lib instead.