Dismissing PR preview banner loses position on the page #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

hugovk opened this issue Feb 9, 2024 · 3 comments · Fixed by #251

Assignees

Labels

Accepted Bug

hugovk commented Feb 9, 2024

Details

Read the Docs project URL: https://readthedocs.org/projects/pep-previews/
Build URL (if applicable): https://readthedocs.org/projects/pep-previews/builds/23392643/

Go to https://pep-previews--3649.org.readthedocs.build/pep-0742/#type-narrowing-behavior

You are taken to the desired page and anchor, but a banner is displayed with the text

This page was created from a pull request build

See the build's detail page or pull request readthedocs/readthedocs.org#3649 for more information.

Click the 'x' to dismiss the banner

Expected Result

Stay in the same position on the page.

Actual Result

Takes you to the top of the page.

See also

Originally reported at python/peps#3657

hugovk changed the title ~~Dismissing PR preview banner loses position on the apge~~ Dismissing PR preview banner loses position on the page

hugovk mentioned this issue

"created from a pull request" banner loses position when closed python/peps#3657

Closed

Member

humitos commented Feb 9, 2024

Thanks for reporting this. I'm moving it to the addons repository since the issue is on the beta addons.

humitos transferred this issue from readthedocs/readthedocs.org

humitos added this to 📍Roadmap

github-project-automation bot moved this to Planned in 📍Roadmap

humitos added Bug Accepted labels

humitos self-assigned this

humitos added a commit that referenced this issue


          Notifications: don't go to top page when closing it

f97f5b6

* When clicking on the X, now it calls `preventDefault()` to avoid moving to the top
* I added some `id=` attributes in the index page to test this manually

Closes #246

humitos mentioned this issue

Notifications: don't go to top page when closing it #251

Merged

humitos moved this from Planned to Needs review in 📍Roadmap

humitos closed this as completed in #251

humitos added a commit that referenced this issue


          Notifications: don't go to top page when closing it (#251)

6b0fd20

* When clicking on the X, now it calls `preventDefault()` to avoid
moving to the top
* I added some `id=` attributes in the index page to test this manually

Closes #246

github-project-automation bot moved this from Needs review to Done in 📍Roadmap

Member

ericholscher commented Feb 20, 2024

This should now be deployed, and I confirmed it's working 👍

Author

hugovk commented Feb 20, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment