Skip to content

src/ReactDOMRe.mlast.d and src/ReactDOMRe.cmj aren't in the downloaded reason-react module and require a build #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcardell opened this issue Mar 13, 2019 · 1 comment

Comments

@alexcardell
Copy link

alexcardell commented Mar 13, 2019

Reason-react is missing two files that need to be produced by bsb -make-world else the app throws errors.

This is problematic in my use case of deploying my reason-react app to Google App Engine (Standard environment), where one can only push built code and App Engine does the install step. A postinstall script isn't viable: it supports a gcp-build script that will run after install, but looking at the logs it will delete node_modules and reinstall with the --production flag, so the created files would be deleted anyway.

Example (given no node_modules directory):

$ yarn install --prod                                                                                      
yarn install v1.13.0
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
✨  Done in 7.10s.
$ bsb -make-world
[18/18] Building src/ReactDOMRe.mlast.d
[9/9] Building src/ReactDOMRe.cmj
ninja: no work to do.

ReactDOMRe seems to be the only package where this happens. Is this intentional? Is it common practice to require a dependency to go through this build step?

@alexcardell alexcardell changed the title src/ReactDOMRe.mlast.d and src/ReactDOMRe.cmj aren't in the downloaded reason-react module src/ReactDOMRe.mlast.d and src/ReactDOMRe.cmj aren't in the downloaded reason-react module and require a build Mar 13, 2019
@alexcardell
Copy link
Author

Covered by rescript-lang/rescript#3276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant