Skip to content

src/ReactDOMRe.mlast.d and src/ReactDOMRe.cmj aren't in the downloaded reason-react module and require a build #352

Closed
@alexcardell

Description

@alexcardell

Reason-react is missing two files that need to be produced by bsb -make-world else the app throws errors.

This is problematic in my use case of deploying my reason-react app to Google App Engine (Standard environment), where one can only push built code and App Engine does the install step. A postinstall script isn't viable: it supports a gcp-build script that will run after install, but looking at the logs it will delete node_modules and reinstall with the --production flag, so the created files would be deleted anyway.

Example (given no node_modules directory):

$ yarn install --prod                                                                                      
yarn install v1.13.0
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
✨  Done in 7.10s.
$ bsb -make-world
[18/18] Building src/ReactDOMRe.mlast.d
[9/9] Building src/ReactDOMRe.cmj
ninja: no work to do.

ReactDOMRe seems to be the only package where this happens. Is this intentional? Is it common practice to require a dependency to go through this build step?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions