Skip to content

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Jul 21, 2025

@DaniPopes DaniPopes requested a review from prestwich as a code owner July 21, 2025 16:04
Copy link

codspeed-hq bot commented Jul 21, 2025

CodSpeed Performance Report

Merging #503 will not alter performance

Comparing DaniPopes:msrv-1.85 (b0aed05) with main (e91a45f)1

Summary

✅ 351 untouched benchmarks

Footnotes

  1. No successful run was found on main (b0aed05) during the generation of this report, so e91a45f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@prestwich
Copy link
Collaborator

stated MSRV policy is 6 months, no?

@DaniPopes
Copy link
Contributor Author

DaniPopes commented Jul 22, 2025

1.85 was released on 20 February, 2025 so I'd say close enough if you round up

@DaniPopes DaniPopes force-pushed the msrv-1.85 branch 2 times, most recently from 3e8eacb to 2e869f7 Compare July 27, 2025 12:43
@gakonst gakonst enabled auto-merge August 4, 2025 18:06
@prestwich
Copy link
Collaborator

@gakonst please don't approve PRs without reading relevant comments. This is in violation of our msrv policy as stated in the readme

@prestwich prestwich marked this pull request as draft August 4, 2025 18:09
auto-merge was automatically disabled August 4, 2025 18:09

Pull request was converted to draft

@prestwich prestwich requested a review from gakonst August 4, 2025 18:09
@DaniPopes DaniPopes marked this pull request as ready for review August 22, 2025 17:09
@prestwich
Copy link
Collaborator

:)

@prestwich prestwich enabled auto-merge August 25, 2025 13:09
@prestwich prestwich merged commit f297716 into recmo:main Aug 25, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment