-
Notifications
You must be signed in to change notification settings - Fork 59
feat: bump MSRV to 1.85 #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #503 will not alter performanceComparing Summary
Footnotes |
stated MSRV policy is 6 months, no? |
1.85 was released on 20 February, 2025 so I'd say close enough if you round up |
3e8eacb
to
2e869f7
Compare
gakonst
approved these changes
Aug 4, 2025
@gakonst please don't approve PRs without reading relevant comments. This is in violation of our msrv policy as stated in the readme |
prestwich
approved these changes
Aug 22, 2025
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows usage of
&mut
inconst fn
,const {}
blocks, many new standard library functions in const and runtime.1.85 was chosen for edition 2024, and it's now 3 versions old.
Unblocks #449.
base_convert
: MSRV-1.80): let as_slice = buf.as_flattened_mut(); #504fmt
: MSRV-1.67): =Self::MAX.ilog(Self::BASE)
#499ilog
when MSRV is 1.67 or greater #498bytes
: Use aconst {}
block for this assertion #283bytes
: Use aconst {}
block for this assertion #282bytes
: Use aconst {}
block for this assertion #281support/scale
: Use nightly generic const expressions to validate that BITS parameter #188lib
: BLOCKED) Many functions could be madeconst
if a number of #88bytes
: BLOCKED) Makeconst fn
s whenconst_for
is stable. #86