Skip to content

fix(e2e): fix openapi git url #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nilgaar
Copy link
Contributor

@nilgaar nilgaar commented Nov 5, 2024

Description

fixing e2e, as openapi example is moved into a new repo:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/periodic-ci-janus-idp-backstage-showcase-release-1.3-e2e-tests-nightly/1853678691410776064/artifacts/e2e-tests-nightly/janus-idp-backstage-showcase-release-1.3-nightly/artifacts/showcase-ci-nightly/index.html#?testId=d49d675e7afa73fe2c07-0f496372062f0d27578a

reference:
OAI/OpenAPI-Specification#4172
https://redhat-internal.slack.com/archives/C07D05S8U82/p1730789892014959

Which issue(s) does this PR fix

no ticket open

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@nilgaar nilgaar requested a review from a team as a code owner November 5, 2024 09:27
Copy link

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rm3l for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nilgaar nilgaar changed the title fix openapi git url e2e: fix openapi git url Nov 5, 2024
Copy link

sonarqubecloud bot commented Nov 5, 2024

@nilgaar nilgaar changed the title e2e: fix openapi git url fix(e2e): fix openapi git url Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1878!

@nilgaar nilgaar closed this Nov 5, 2024
@nilgaar nilgaar deleted the e2e/fixTestsNov24 branch November 5, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant