-
Notifications
You must be signed in to change notification settings - Fork 46
Add CONTRIBUTING Guidelines #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
847dcef
a9683c0
29a4ba6
62d84ff
d33f04a
2c72362
c31fd43
d7e2237
3be1998
dde634b
44dc452
d87f744
b0dd686
c7c2d55
3a81b0b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,22 @@ | ||
cli | ||
codecov | ||
Codecov | ||
dotnet | ||
firsttimersonly | ||
github | ||
HSET | ||
http | ||
Json | ||
json | ||
makeapullrequest | ||
NRedisStack | ||
NuGet | ||
OSS | ||
StackExchange | ||
TimeSeries | ||
cli | ||
codecov | ||
dotnet | ||
github | ||
json | ||
oss | ||
pre | ||
redis | ||
StackExchange | ||
TimeSeries | ||
triaging | ||
www | ||
yml |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,103 @@ | ||||||||
# Contributing | ||||||||
|
||||||||
## Introduction | ||||||||
|
||||||||
We appreciate your interest in contributing to NRedisStack. | ||||||||
Community contributions mean a lot to us. | ||||||||
|
||||||||
## Contributions we need | ||||||||
|
||||||||
You may already know how you'd like to contribute, whether it's a fix for a bug you | ||||||||
encountered, or a new feature your team wants to use. | ||||||||
|
||||||||
If you don't know where to start, consider improving | ||||||||
documentation, triaging bugs, or writing tutorials. These are all examples of | ||||||||
helpful contributions that mean less work for you. | ||||||||
|
||||||||
## Your First Contribution | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
Unsure where to begin contributing? You can start by looking through | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
[help-wanted | ||||||||
issues](https://github.com/redis/NRedisStack/labels/help-wanted). | ||||||||
|
||||||||
Never contributed to open source before? Here are a couple of friendly | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
tutorials: | ||||||||
|
||||||||
- <http://makeapullrequest.com/> | ||||||||
- <http://www.firsttimersonly.com/> | ||||||||
|
||||||||
## Getting Started | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
Here's how to get started with your code contribution: | ||||||||
|
||||||||
1. Create your own fork of NRedisStack | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
2. Do the changes in your fork | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
3. Write your tests | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
4. Use the `docker run -p 6379:6379 -it redis/redis-stack-server:edge` as your local environment for running the functional tests. | ||||||||
5. Make sure your tests pass using `dotnet test' | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
6. Push your changes to GitHub | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
7. Open a pull request | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
## Testing | ||||||||
|
||||||||
Call `dotnet test` to run all tests | ||||||||
|
||||||||
to test specific test you can use `--filter` flag: | ||||||||
```bash | ||||||||
dotnet test --filter <YourTestName> | ||||||||
``` | ||||||||
|
||||||||
If you want to run your tests against a specific host and port, you can do it thus: | ||||||||
```bash | ||||||||
dotnet test --environment="REDIS=<redisServer:port>" | ||||||||
``` | ||||||||
e.g: | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
```bash | ||||||||
dotnet test --environment="REDIS=172.17.0.1:6379" | ||||||||
``` | ||||||||
## How to Report a Bug | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
### Security Vulnerabilities | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
**NOTE**: If you find a security vulnerability, do NOT open an issue. | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
Email [Redis Open Source (<[email protected]>)](mailto:[email protected]) instead. | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
In order to determine whether you are dealing with a security issue, ask | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
yourself these two questions: | ||||||||
|
||||||||
- Can I access something that's not mine, or something I shouldn't | ||||||||
have access to? | ||||||||
- Can I disable something for other people? | ||||||||
|
||||||||
If the answer to either of those two questions are *yes*, then you're | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
probably dealing with a security issue. Note that even if you answer | ||||||||
*no* to both questions, you may still be dealing with a security | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
issue, so if you're unsure, just email [us](mailto:[email protected]). | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
### Everything Else | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
When filing an issue, make sure to answer these five questions: | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
1. What version of NRedisStack are you using? | ||||||||
2. What version of redis are you using? | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
3. What did you do? | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
4. What did you expect to see? | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
5. What did you see instead? | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
## Suggest a feature or enhancement | ||||||||
|
||||||||
If you'd like to contribute a new feature, make sure you check our | ||||||||
issue list to see if someone has already proposed it. Work may already | ||||||||
be underway on the feature you want or we may have rejected a | ||||||||
feature like it already. | ||||||||
|
||||||||
If you don't see anything, open a new issue that describes the feature | ||||||||
you would like and how it should work. | ||||||||
|
||||||||
## Code review process | ||||||||
|
||||||||
The core team regularly looks at pull requests. We will provide | ||||||||
feedback as as soon as possible. After receiving our feedback, please respond | ||||||||
within two weeks. After that time, we may close your PR if it isn't | ||||||||
showing any activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.