Skip to content

Add CONTRIBUTING Guidelines #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 2, 2023
Merged
20 changes: 13 additions & 7 deletions .github/wordlist.txt
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
cli
codecov
Codecov
dotnet
firsttimersonly
github
HSET
http
Json
json
makeapullrequest
NRedisStack
NuGet
OSS
StackExchange
TimeSeries
cli
codecov
dotnet
github
json
oss
pre
redis
StackExchange
TimeSeries
triaging
www
yml
103 changes: 103 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
# Contributing

## Introduction

We appreciate your interest in contributing to NRedisStack.
Community contributions mean a lot to us.

## Contributions we need

You may already know how you'd like to contribute, whether it's a fix for a bug you
encountered, or a new feature your team wants to use.

If you don't know where to start, consider improving
documentation, triaging bugs, or writing tutorials. These are all examples of
helpful contributions that mean less work for you.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
helpful contributions that mean less work for you.
helpful contributions.


## Your First Contribution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Your First Contribution
## Your first contribution


Unsure where to begin contributing? You can start by looking through
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Unsure where to begin contributing? You can start by looking through
To orient yourself, take a look at

[help-wanted
issues](https://github.com/redis/NRedisStack/labels/help-wanted).

Never contributed to open source before? Here are a couple of friendly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Never contributed to open source before? Here are a couple of friendly
If you've not contributed to open source before, check out a couple of friendly

tutorials:

- <http://makeapullrequest.com/>
- <http://www.firsttimersonly.com/>

## Getting Started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Getting Started
## Get started


Here's how to get started with your code contribution:

1. Create your own fork of NRedisStack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Create your own fork of NRedisStack
1. Create your own fork of NRedisStack.

2. Do the changes in your fork
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Do the changes in your fork
1. Make changes in your fork.

3. Write your tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Write your tests
1. Write your tests.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

4. Use the `docker run -p 6379:6379 -it redis/redis-stack-server:edge` as your local environment for running the functional tests.
5. Make sure your tests pass using `dotnet test'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. Make sure your tests pass using `dotnet test'
1. Check that your tests pass using `dotnet test'.

6. Push your changes to GitHub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
6. Push your changes to GitHub
1. Commit your changes to GitHub.

7. Open a pull request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
7. Open a pull request
1. Open a pull request.


## Testing

Call `dotnet test` to run all tests

to test specific test you can use `--filter` flag:
```bash
dotnet test --filter <YourTestName>
```

If you want to run your tests against a specific host and port, you can do it thus:
```bash
dotnet test --environment="REDIS=<redisServer:port>"
```
e.g:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
e.g:
Example:

```bash
dotnet test --environment="REDIS=172.17.0.1:6379"
```
## How to Report a Bug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## How to Report a Bug
## Report a bug


### Security Vulnerabilities
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Security Vulnerabilities
### Security vulnerabilities


**NOTE**: If you find a security vulnerability, do NOT open an issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**NOTE**: If you find a security vulnerability, do NOT open an issue.
**NOTE**: If you find a security vulnerability, do _not_ open an issue.

Email [Redis Open Source (<[email protected]>)](mailto:[email protected]) instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Email [Redis Open Source (<[email protected]>)](mailto:[email protected]) instead.
Instead, email [Redis Open Source (<[email protected]>)](mailto:[email protected]).


In order to determine whether you are dealing with a security issue, ask
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to determine whether you are dealing with a security issue, ask
To determine whether you are dealing with a security issue, ask

yourself these two questions:

- Can I access something that's not mine, or something I shouldn't
have access to?
- Can I disable something for other people?

If the answer to either of those two questions are *yes*, then you're
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If the answer to either of those two questions are *yes*, then you're
If the answer to either of those two questions is _yes_, you're

probably dealing with a security issue. Note that even if you answer
*no* to both questions, you may still be dealing with a security
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*no* to both questions, you may still be dealing with a security
_no_ to both questions, you may still be dealing with a security

issue, so if you're unsure, just email [us](mailto:[email protected]).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
issue, so if you're unsure, just email [us](mailto:[email protected]).
issue. So, if you're unsure, just email [us](mailto:[email protected]).


### Everything Else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Everything Else
### Issue checklist


When filing an issue, make sure to answer these five questions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When filing an issue, make sure to answer these five questions:
When submitting an issue, make sure to answer these five questions:


1. What version of NRedisStack are you using?
2. What version of redis are you using?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. What version of redis are you using?
1. What version of redis are you using?

3. What did you do?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. What did you do?
1. What steps did you perform?

4. What did you expect to see?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. What did you expect to see?
1. What did you expect to see?

5. What did you see instead?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. What did you see instead?
1. What did you see instead?


## Suggest a feature or enhancement

If you'd like to contribute a new feature, make sure you check our
issue list to see if someone has already proposed it. Work may already
be underway on the feature you want or we may have rejected a
feature like it already.

If you don't see anything, open a new issue that describes the feature
you would like and how it should work.

## Code review process

The core team regularly looks at pull requests. We will provide
feedback as as soon as possible. After receiving our feedback, please respond
within two weeks. After that time, we may close your PR if it isn't
showing any activity.