Skip to content

#RI-4826 - add default value for code #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023
Merged

#RI-4826 - add default value for code #2470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ui/src/pages/triggeredFunctions/pages/Libraries/components/AddLibrary/AddLibrary.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ describe('AddLibrary', () => {
expect(render(<AddLibrary {...mockedProps} />)).toBeTruthy()
})

it('should display proper code value by default', () => {
render(<AddLibrary {...mockedProps} />)

expect(screen.getByTestId('code-value')).toHaveValue('#!js name=LibName api_version=1.0')
})

it('should call proper telemetry event', async () => {
const onAdded = jest.fn()

Expand Down
2 changes: 1 addition & 1 deletion ...ight/ui/src/pages/triggeredFunctions/pages/Libraries/components/AddLibrary/AddLibrary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const LibraryDetails = (props: IProps) => {

const { loading } = useSelector(triggeredFunctionsAddLibrarySelector)

const [code, setCode] = useState<string>('')
const [code, setCode] = useState<string>('#!js name=LibName api_version=1.0')
const [configuration, setConfiguration] = useState<string>('')
const [isShowConfiguration, setIsShowConfiguration] = useState<boolean>(false)

Expand Down
2 changes: 2 additions & 0 deletions .../ui/src/pages/triggeredFunctions/pages/Libraries/components/AddLibrary/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
height: 100%;
max-height: calc(100% - 104px);
margin-bottom: 46px;

overflow-x: hidden;
}

.label {
Expand Down