RI-7091 - add an environment variable to skip the eula screen #4556
Conversation
…al implementation. Check vite.config!
KIvanow
requested review from
KrumTy,
pawelangelow,
dantovska,
ArtemHoruzhenko and
pd-redis
as code owners
…ed hard coded variables approach as per Artem's feedback
…ed integration test cases
…ed webpack config
| style={{ marginTop: '12px' }} | ||
| > | ||
| {parse(consent.description)} | ||
| {getText()} |
There was a problem hiding this comment.
a more React way would be to use jsx instead of a function call
| {getText()} | |
| <ItemDescription description={consent.description && parse(consent.description)} withLink={linkToPrivacyPolicy} /> |
and can define the component outside ConsentOption
There was a problem hiding this comment.
It would be a more React way. However I am not sure creating a component that will be used only in this case and prop drill it with the data from the parent one is optimal either.
Is there another benefit of not having a function call, other than sticking to jsx?
There was a problem hiding this comment.
+1 to @KrumTy suggestion
Honestly can't figure out a major benefit, but the produced code looks better and simpler, and maybe the most important part - generally sets the tone to not use it, especially on places where some things can be reused or simplified 😄
There was a problem hiding this comment.
the produced code looks better and simpler, and maybe the most important part - generally sets the tone to not use it, especially on places where some things can be reused or simplified
I am not sure how the code looks better and simpler, but also sets the tone of not using it. This seems like a contradiction.
Anyway, I replaced a function call with 2 separate files and a folder. Even has an index.tsx to re-export it to follow all React patterns.
redisinsight/api/src/modules/settings/repositories/agreements.repository.ts
Outdated
Show resolved
Hide resolved
redisinsight/api/src/modules/settings/repositories/local.agreements.repository.ts
Outdated
Show resolved
Hide resolved
|
@KIvanow could you please look on this. https://github.com/RedisInsight/RedisInsight/pull/4567/files |
…nvironment-variable-to-skip-the-EULA-screen-suggestion RI-7091 rework repository
… encryption available utility method
| } catch (e) { | ||
| if (e.code === 'SQLITE_CONSTRAINT') { | ||
| return this.getOrCreate(); | ||
| return this.getOrCreate(sessionMetadata); |
There was a problem hiding this comment.
If this is a retry, shouldn't it pass the options as well?
| return this.getOrCreate(sessionMetadata); | |
| return this.getOrCreate(sessionMetadata, defaultOptions); |
…cing a function call with 3 files and a folder
KIvanow
deleted the
feature/RI-7091---Add-an-environment-variable-to-skip-the-EULA-screen
branch
No description provided.