RI-7077: do not switch to cluster if force standalone is set #4569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd-redis
requested review from
KrumTy,
pawelangelow,
dantovska,
ArtemHoruzhenko and
KIvanow
as code owners
| * Fetches cluster nodes | ||
| * Creates cluster client to validate connection. Disconnect after check | ||
| * Creates database model for cluster connection type | ||
| * @param sessionMetadata |
There was a problem hiding this comment.
I'm wondering why these appeared here. Doesn't seem connected to the standalone issue
There was a problem hiding this comment.
because it was missing, which triggers eslint warnings ;)
| client, | ||
| ); | ||
| } else if (await isCluster(client)) { | ||
| } else if ((await isCluster(client)) && !database.forceStandalone) { |
There was a problem hiding this comment.
lets guard it with a test
| client, | ||
| ); | ||
| } else if (await isCluster(client)) { | ||
| } else if ((await isCluster(client)) && !database.forceStandalone) { |
There was a problem hiding this comment.
I would suggest you to not even start discovering database type if database.forceStandalone flag is true
just return model immediately on line 66.
KIvanow
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when creating database model, force standalone option was being ignored