Skip to content

HIncrBy missing from HashCmdable #3343

Closed
@AvyChanna

Description

@AvyChanna

#3305 adds HIncrByFloat but removes the normal HIncrBy, that used int64. This breaks older clients that use UniversalClients.

I don't think this was intentional, since the function still exists. Just the interface is not exposing it anymore.

Expected Behavior

HashCmdable should have HIncrBy like so -

type HashCmdable interface {
	...
	HIncrBy(ctx context.Context, key, field string, incr int64) *IntCmd
	HIncrByFloat(ctx context.Context, key, field string, incr float64) *FloatCmd
	...
}

Activity

ndyakov

ndyakov commented on Apr 15, 2025

@ndyakov
Member

@AvyChanna Thank you for reporting! Looking into this.

ndyakov

ndyakov commented on Apr 15, 2025

@ndyakov
Member

Fixed by #3344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ndyakov@AvyChanna

        Issue actions

          HIncrBy missing from HashCmdable · Issue #3343 · redis/go-redis