Skip to content

Fix/issue 1384 #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 13, 2020
Merged

Fix/issue 1384 #1529

merged 8 commits into from
Oct 13, 2020

Conversation

tty2
Copy link
Contributor

@tty2 tty2 commented Oct 11, 2020

fix #1384
Add time.Time type to Scan method.

PAY ATTENTION: there is a questionable part. I've added function level nolint: gocyclo cause with +1 branch limit is broken.
I can split the switch inside to 2 parts and move them to separate functions. And remove nolint of course. But IMHO the function will lose current readability.
WDYT?

@vmihailenco
Copy link
Collaborator

And remove nolint of course. But IMHO the function will lose current readability. WDYT?

I am fine with nolint.

@vmihailenco
Copy link
Collaborator

Thanks, merging.

I had to move package to proto_test. Otherwise I had circular imports.

I will move the test to redis_test.go.

@vmihailenco vmihailenco merged commit f169894 into redis:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time.UnmarshalBinary: unsupported version
2 participants