Skip to content

feat: Add support for new redis command CLIENT NO-TOUCH #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

feat: Add support for new redis command CLIENT NO-TOUCH #2551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5887cbb
Implemented feature for `CLIENT NO-TOUCH <ON | OFF>`
ktsivkov Apr 18, 2023
547b90f
Merge branch 'master' into client-no-touch
ktsivkov Apr 20, 2023
2c04529
move: commands to StatusCmd
SoulPancake Apr 21, 2023
f583ce4
Update commands.go
SoulPancake Apr 21, 2023
6e32a93
Update commands_test.go
SoulPancake Apr 21, 2023
5be3abd
Merge pull request #5 from SoulPancake/patch-2
ktsivkov Apr 21, 2023
49e3ea0
Merge pull request #4 from SoulPancake/patch-1
ktsivkov Apr 21, 2023
ba16ce4
Merge pull request #3 from SoulPancake/cnt
ktsivkov Apr 21, 2023
05134b2
Fixed naming of ClientNoTouch commands
ktsivkov Apr 22, 2023
2ec6cc3
Merge branch 'master' into client-no-touch
chayim Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ type Cmdable interface {
CommandGetKeys(ctx context.Context, commands ...interface{}) *StringSliceCmd
CommandGetKeysAndFlags(ctx context.Context, commands ...interface{}) *KeyFlagsCmd
ClientGetName(ctx context.Context) *StringCmd
ClientNoTouchOn(ctx context.Context) *StatusCmd
ClientNoTouchOff(ctx context.Context) *StatusCmd
Echo(ctx context.Context, message interface{}) *StringCmd
Ping(ctx context.Context) *StatusCmd
Quit(ctx context.Context) *StatusCmd
Expand Down Expand Up @@ -3144,6 +3146,18 @@ func (c cmdable) ClientKill(ctx context.Context, ipPort string) *StatusCmd {
return cmd
}

func (c cmdable) ClientNoTouchOn(ctx context.Context) *StatusCmd {
cmd := NewStatusCmd(ctx, "client", "no-touch", "on")
_ = c(ctx, cmd)
return cmd
}

func (c cmdable) ClientNoTouchOff(ctx context.Context) *StatusCmd {
cmd := NewStatusCmd(ctx, "client", "no-touch", "off")
_ = c(ctx, cmd)
return cmd
}

// ClientKillByFilter is new style syntax, while the ClientKill is old
//
// CLIENT KILL <option> [value] ... <option> [value]
Expand Down
10 changes: 10 additions & 0 deletions commands_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,16 @@ var _ = Describe("Commands", func() {
Expect(r.Val()).To(Equal(""))
})

It("should ClientNoTouch", func() {
r := client.ClientNoTouchOn(ctx)
Expect(r.Err()).NotTo(HaveOccurred())
Expect(r.Val()).To(Equal("OK"))

r = client.ClientNoTouchOff(ctx)
Expect(r.Err()).NotTo(HaveOccurred())
Expect(r.Val()).To(Equal("OK"))
})

It("should ClientKillByFilter", func() {
r := client.ClientKillByFilter(ctx, "TYPE", "test")
Expect(r.Err()).To(MatchError("ERR Unknown client type 'test'"))
Expand Down